Bug in Skill "Hard Hit" (Fix included)

[noamik]

The minimum damage doesn't get increased as advertised. I have fixed this in my repo in commit: https://github.com/noamik/andors-trail/ ... ab229fe70d

Where should I direct a merge request?

[Zukero]

Noamik,

You "fixed" this the right way, except this is no bug. Hard hit raises "max damage" only. It gives a 0-2 AD boost as planned.

[rijackson741]

It gives a 0-2 AD boost as planned.

Although it seems not necessarily as desired
http://andorstrail.com/viewtopic.php?f= ... t=hard+hit

[noamik]

Zukero: if my fix is wrong, then the skill description is as well. It clearly reads:

Increases min and max damage by %1$d for each skill level.

https://code.google.com/r/euanjt-andor- ... ame=master

If "Hard Hit" should really only increase the max, it would be rather useless IMO ...

Edit: Either way a bug needs to be fixed

[Zukero]

You are looking at the wrong gcode repo.

The right one is there http://code.google.com/p/andors-trail/s ... trings.xml

[noamik]

Actually I was looking onto my device where I was playing 0.7.1 from the app store. It's still wrong there. I had only googled for the repo reference. Good to know that this has already been fixed für 0.7.2. Can be closed then. And sorry for the inconvenience.

[Zukero]

V0.7.1 already had the correct string. I checked in the sources.
Are you using Andor's Trail by Oskar Wiksten from Google Play (https://play.google.com/store/apps/deta ... ndorsTrail) ?

[noamik]

I'm playing on a german phone and it definitely doesn't have the correct string in german. And yes, that is the one I'm using.

[Zukero]

Ok, it's a translation bug then. I bet it's been fixed in the mean time, as our german translators have been pretty active since v0.7.1 came out.

You can check in my github repo, under branch "translations", in res/values-de/strings.xml, and see for yourself. My german is worthless, so I won't even try to open this file

Auf wiedersehen.

Edit: well, I checked it anyway, and it's not up to date. Since you know how to make pull requests, maybe you can open one against my "translations" branch, with updated values-de/strings.xml ?

[noamik]

Ok, so I guess the real "bug" is English strings.xml being updated but no notification to translators being generated. This issue could be addressed by one of two approaches. You could either version the string references. Or you could invalidate (read remove) translations. This should be done when changing the meaning of an English string.

I fixed the translations for German and French: https://github.com/noamik/andors-trail/ ... f3dda0942a

Edit: I created a pull request for it as requested: https://github.com/Zukero/andors-trail/pull/2

TODO: pt and pt-rBR are wrong as well and need fixing.
TODO: ru, ja and pl need to be checked by translators and be removed in case of doubt to give future translators a chance to fix the translation.