v0.8.9 (Bugfixes + translations) released to Google Play!

Useful links
Source code of the game - Contribution guide - ATCS Editor - Translate the game on Weblate - Example walkthrough - Andor's Trail Directory - Join the Discord
Get the game (v0.8.9) from Google, F-Droid, our server, or itch.io

Not bugs but typos...

A place to submit bugs to the Andor's Trail Development Team.
Post Reply
User avatar
Duvalon
VIP
Posts: 73
Joined: Wed Oct 19, 2016 1:34 am
android_version: 7.1 - Nougat
Location: Canada

Re: Not bugs but typos...

Post by Duvalon »

I think ctebeh's cynical remarks are misleading. This is an open source project. It's not that people don't care but sometimes life takes precedence over hobbies. Please do share on the forums so that someone may address these issues... Eventually. (Edit: rijackson beat me to it!)

That being said, I agree with auroradormita. The sentence is awkward no matter the intended meaning. I'd have to look at the conversation context but just for that sentence I'd be inclined to go with "We spend most of our time..."

If you're inclined to correct typos and grammatical errors like this one yourself, I would recommend making your own fork on github, and start fixing them in it. The conversations are in plain text so you can search them and modify them easily (don't need Android studio, or even ATCS). I think you can even commit through the github website. When you have a few commits or you're otherwise done, just submit a pull request on Zukero's repository.
Last edited by Duvalon on Fri Jan 06, 2017 9:40 pm, edited 1 time in total.
User avatar
Duvalon
VIP
Posts: 73
Joined: Wed Oct 19, 2016 1:34 am
android_version: 7.1 - Nougat
Location: Canada

Re: Not bugs but typos...

Post by Duvalon »

Let's try to keep this conversation on topic, please. If you wish to argue about life, the universe and everything, start another thread or use PMs.
auroradormita
Posts: 33
Joined: Sat Dec 31, 2016 10:24 pm
android_version: 6.0 - Marshmallow

Re: Not bugs but typos...

Post by auroradormita »

Oh help, didn't mean to make you so mad.

Was just wondering; maybe this whole thread was dead and I was just wasting my energy by posting since nothing would ever be done anyway? So was wondering if it was worth posting if I found something else? A yes or no answer would have been enough.

I wasn't necessarily asking you personally. Like maybe someone would answer "no, we already decided long ago these things aren't worth correcting". Instead, several answered "yes we would like to fix them" even though you personally ctnbeh aren't interested in doing so at this time. I'm pretty new on these forums so that's why I was asking what the policy was. Again, sorry that you thought I was criticizing you.
Tomcat
VIP
Posts: 1353
Joined: Tue Feb 08, 2011 7:05 am
android_version: 7.0

Re: Not bugs but typos...

Post by Tomcat »

No, don't give up just because one person posts something negative
Norbert
Lvl:52 XP:2597576 AP:12 HP:124 AC:282 AD:30-42 CHS:27 CM:2.0 ECC:18% BC:132 DR:2
Skills: CS:2 IF:2 Ev:3 Rg:1 DgPro:1 1HPro:2 LtAPro:2 FS-DW:2 Sp-DW:1
Equip: FP BSS JoF RoP PRoB SrpHbk GoLF EnhCH EnhCB
Other: DotSP VD GoW FB TG RoD+6 Oegyth:6
auroradormita
Posts: 33
Joined: Sat Dec 31, 2016 10:24 pm
android_version: 6.0 - Marshmallow

Re: Not bugs but typos...

Post by auroradormita »

I'm not giving up, just saying I didn't mean to get anyone mad.
User avatar
rijackson741
Posts: 4447
Joined: Tue Aug 20, 2013 2:04 am
android_version: 10 - Android 10
Location: Somewhere in Dhayavar
Contact:

Re: Not bugs but typos...

Post by rijackson741 »

Duvalon wrote:If you're inclined to correct typos and grammatical errors like this one yourself, I would recommend making your own fork on github, and start fixing them in it.
If you are not a professional developer (as you are), that's a lot of work. For simple typos and weird English, if they are posted here I'll catch them, and fix them. They won't individually get pushed to github, but they will eventually get collectively pushed there.
Level:71, XP:6493739, PV:608, FQ:84
HP:210, AC:212, AD:58-77, AP:4, ECC:16%, CM:1.5, BC:188, DR:3
Gold: 237559 | RoLS:1, RoL:1, GoW:1, VSH:1, RoFLS:1, WoB:1
HH:1, WA:1, CS:2, Cl:1, IF:4, Ev:3, Re:2, WP:DA:1, WP:1S:1, WP:B:1, AP:L:1, FS:DW:2, S:DW:1
User avatar
rijackson741
Posts: 4447
Joined: Tue Aug 20, 2013 2:04 am
android_version: 10 - Android 10
Location: Somewhere in Dhayavar
Contact:

Re: Not bugs but typos...

Post by rijackson741 »

ctnbeh13 wrote:This practice sadly ended after I left.
No, it didn't. It changed, but it did not end,
ctnbeh13 wrote:is any assistance or help welcomed (regardless of this answer, who's taking care of fulfilling all of the offers that are being rejected), etc.
Which offers are being rejected? None that I know of.
Level:71, XP:6493739, PV:608, FQ:84
HP:210, AC:212, AD:58-77, AP:4, ECC:16%, CM:1.5, BC:188, DR:3
Gold: 237559 | RoLS:1, RoL:1, GoW:1, VSH:1, RoFLS:1, WoB:1
HH:1, WA:1, CS:2, Cl:1, IF:4, Ev:3, Re:2, WP:DA:1, WP:1S:1, WP:B:1, AP:L:1, FS:DW:2, S:DW:1
User avatar
Zukero
Lead Developer
Posts: 2028
Joined: Thu Jul 21, 2011 9:56 am
android_version: 8.0
Location: Eclipse

Re: Not bugs but typos...

Post by Zukero »

@auroradormita thanks for reporting this. This kind of issues are easy to overlook, and I find it very helpful to benefit from the fresh eyes of newcomers to spot these.

@Duvalon I found your replies totally appropriate, and completely in-line with the "editorial line" of the forums. I have to agree with rijackson that forking and making a PR aren't exactly beginner friendly (easier than it sounds, but not for everyone) though, but it was worth mentioning (who said auroradormita wan't a professional developer ?).

@ctnbeh13 ?? I saw no offense given. I am surprised by your reaction.
Lvl: 78, XP: 8622632, Gold: 271542, RoLS: 1, ElyR: -, RoL: -, ChaR: 1, GoLF: 1, ShaF: 1, SRoV: 1, VSH: 1, WMC: 1, GoW: 1
HP: 71, AC: 301%, AD: 38-47, AP: 3, ECC: 50%, CM: 3.75, BC: 101%, DR: 2
User avatar
rijackson741
Posts: 4447
Joined: Tue Aug 20, 2013 2:04 am
android_version: 10 - Android 10
Location: Somewhere in Dhayavar
Contact:

Re: Not bugs but typos...

Post by rijackson741 »

Zukero wrote: (who said auroradormita wan't a professional developer ?).
True. An assumption on my part, and possibly an incorrect one :)
Level:71, XP:6493739, PV:608, FQ:84
HP:210, AC:212, AD:58-77, AP:4, ECC:16%, CM:1.5, BC:188, DR:3
Gold: 237559 | RoLS:1, RoL:1, GoW:1, VSH:1, RoFLS:1, WoB:1
HH:1, WA:1, CS:2, Cl:1, IF:4, Ev:3, Re:2, WP:DA:1, WP:1S:1, WP:B:1, AP:L:1, FS:DW:2, S:DW:1
User avatar
rijackson741
Posts: 4447
Joined: Tue Aug 20, 2013 2:04 am
android_version: 10 - Android 10
Location: Somewhere in Dhayavar
Contact:

Re: Not bugs but typos...

Post by rijackson741 »

ctnbeh13 wrote:rijackson741, Okay, so this isn't an Easter Egg hunt. How about instead of hinting that I'm getting warmer when I go left, you just publicly share what's up with what. You say that the practice of transparently sharing information with the public didn't end, it changed. To me, ending is change, and in the current context, not a good one. Care to specifically address and/or elaborate how this process changed?
viewtopic.php?f=5&t=5506
ctnbeh13 wrote:Your 2nd remark seems more rhetorical, so, I would simply ask that you consider taking a moment to express to the community your responsibilities as a new member of the Development Team, and how that may or may not relate to your personal knowledge of what is accepted and rejected. I only suggest clarification here as lack of knowledge does not equate lack of existence. During my membership, such knowledge was shared with all, and a considerable amount of offers were rejected (if not backburnered) with approval from the majority, and believably always with good reasoning.
Your post implied (in fact stated) that offers (I assume by that you meant offers to help) are being rejected. I simply said that I know of no such rejections, but if you do, then please clarify what they are, or were.
Level:71, XP:6493739, PV:608, FQ:84
HP:210, AC:212, AD:58-77, AP:4, ECC:16%, CM:1.5, BC:188, DR:3
Gold: 237559 | RoLS:1, RoL:1, GoW:1, VSH:1, RoFLS:1, WoB:1
HH:1, WA:1, CS:2, Cl:1, IF:4, Ev:3, Re:2, WP:DA:1, WP:1S:1, WP:B:1, AP:L:1, FS:DW:2, S:DW:1
Post Reply