Page 3 of 5

Re: End round at end of combat

Posted: Wed Dec 21, 2016 10:07 pm
by Voom
So Corpse Eater is distinctly useful for fighting mobs. I don't think I agree with this change. It will be ignored in favor of Regen as fighting mobs is not as frequent as fighting a single monster at a time. The trade-off of having both rather than just Regen is worse than before this change. In other words, the opportunity cost is greater than the added benefit of Regen-ing when combat ends.

Maybe I'm wrong. I need to rethink this.

Re: End round at end of combat

Posted: Sun Jan 01, 2017 3:11 am
by Tomcat
Fighting multiple foes will likely become more and more important at higher levels. Just a feeling.

Re: End round at end of combat

Posted: Sun Jan 01, 2017 3:13 am
by nyktos
yeah, my new build is focusing on an end-game that i can't predict...

(gotta have a flexible character to test new versions of the game)

Re: End round at end of combat

Posted: Fri May 19, 2017 3:06 am
by Duvalon
Zukero wrote:
Mon Dec 05, 2016 12:25 pm
Good analysis, but, at a first glance, I'd look into simply changing CombatController.

Try to replace this: ...
by this: ...

Gotta check the side effects though.
Just tried it and it doesn't work. exitCombat() isn't called in newPlayerTurn() when combat ends. It's called from playerActionCompleted(). And actually there are a few other places it seems to get called from like executeMoveAttack(), and MapController.handlePlayerDeath(). Although I think in the case of the latter, if you're dead it won't matter too much.

I agree with Voom that regen would eclipse corpse eater in terms of usefulness if this change was implemented. I'll try my fix next and see if I can't prevent regen from applying in this particular case.

Re: End round at end of combat

Posted: Mon May 22, 2017 7:34 pm
by Duvalon
OK. With my changes it works. And regen isn't triggered because it's not an actor condition, but sustenance from food like meat does apply. It does what I imagined it to do, making negative effects like bleeding and poison more potent (faster acting) but also giving sustenance a boost, allowing meat to heal faster.

The one thing I think doesn't fit is removing this line

Code: Select all

controllers.gameRoundController.resetRoundTimers();
It makes time flow awkward right after a fight; sometimes a round will end very shortly after, in effect going through two rounds at once.

Re: End round at end of combat

Posted: Tue May 23, 2017 4:32 am
by Voom
I thought sustenance already ticks as soon as combat finishes. I just don't think the Regen skill should, otherwise it defeats the purpose of Corps Eater. Am I missing something?

Re: End round at end of combat

Posted: Tue May 23, 2017 10:47 am
by Duvalon
Sustenance and negative effects such as poison currently don't tick as soon as combat finishes. It will tick during combat if you don't kill all the enemies in the first round though.

Like explained at the beginning of the thread, because the round timers are reset at the end of combat, if you just string kills fast enough and kill every monster in the first round you can get by without getting either sustenance or affected by negative effects like bleed or poison.

I found a way to correct that. And regen won't tick at the end of combat so corpse eater still has its usefulness.

Re: End round at end of combat

Posted: Tue May 23, 2017 12:10 pm
by Zukero
I have an issue with this. I breaks the consistency of what a round is.
I'd rather let regen apply, and boost corpse eater to 1-3HP per kill per level.

Re: End round at end of combat

Posted: Tue May 23, 2017 12:41 pm
by rijackson741
Zukero wrote:
Tue May 23, 2017 12:10 pm
I have an issue with this. I breaks the consistency of what a round is.
I agree. If Re is advertised as +1 HP per round, that's what it should be. IMO, everything that is "per round' should be executed at the end of a round, no matter how the round ends. If that makes CE under powered, then we adjust CE.

Re: End round at end of combat

Posted: Tue May 23, 2017 1:12 pm
by Duvalon
Regen is already a bit of an oddball because it doesn't apply in combat, or when otherwise adjacent to a monster. I don't see why it should apply in this case.