Andor's Trail

I have built my character with 1 point in regeneration skill and grabbed the RoLS, so theoretically I have 2 points of regeneration by turn. It seems that I have actually 2 regen when not fighting (every 6 secs), but during fights, I've got only one. Is it normal? From what I read here and here, it's by design: where not in combat, skills (regeneration) + conditions (RoLS) are applied whereas in combat only conditions are applied. First, I was thinking it was linked to stackability, but it sounds for me like a bug.

Then, whereas I have one or two regen points, the blue digit spawning over the head of my character is always indicating ‘1’. Looking at code again, it seems normal as only the condition triggers the blue swirl.

Other question, while killing one monster after another (not in melee), you don't get regeneration between monsters, whereas I was thinking that a ended combat worth a game round. It's not super, because you can lose progressively life when killing a lot of monsters in a row because regen doesn't trigger between monster as I was expecting.

Another question, I don't really grasp, looking at the code, the difference between round and full round. What does it practically mean in the game? It seems that monsters can benefit of conditions every 25 seconds, whereas player benefits every 6 seconds. Am I right?

Last question, what is the contribution flow if, by any chance, I wanted to submit a pull request for fixing those things (if they are to be fixed of course)? Should I open an issue first in GitHub?

PomCompot wrote: ↑Thu Aug 09, 2018 11:43 am I have built my character with 1 point in regeneration skill and grabbed the RoLS, so theoretically I have 2 points of regeneration by turn. It seems that I have actually 2 regen when not fighting (every 6 secs), but during fights, I've got only one. Is it normal? From what I read here and here, it's by design: where not in combat, skills (regeneration) + conditions (RoLS) are applied whereas in combat only conditions are applied. First, I was thinking it was linked to stackability, but it sounds for me like a bug.

It's by design. Regeneration does not work if you are next to a monster. Shadow regeneration works all the time.

PomCompot wrote: ↑Thu Aug 09, 2018 11:43 am Other question, while killing one monster after another (not in melee), you don't get regeneration between monsters, whereas I was thinking that a ended combat worth a game round. It's not super, because you can lose progressively life when killing a lot of monsters in a row because regen doesn't trigger between monster as I was expecting.

This has been fixed for 0.7.2

PomCompot wrote: ↑Thu Aug 09, 2018 11:43 am Another question, I don't really grasp, looking at the code, the difference between round and full round. What does it practically mean in the game? It seems that monsters can benefit of conditions every 25 seconds, whereas player benefits every 6 seconds. Am I right?

The only difference is the time: 6s vs 25s. A condition that acts every full round would act once every 25s (there are no such conditions in 0.7.1 though)

PomCompot wrote: ↑Thu Aug 09, 2018 11:43 am Last question, what is the contribution flow if, by any chance, I wanted to submit a pull request for fixing those things (if they are to be fixed of course)? Should I open an issue first in GitHub?

For the above, there's nothing to fix, but you would fork Zukero's repo, and then make your changes in your copy of the repo (preferably after creating a new branch), then put in a pull request. Before doing any of that it's best to ask here first though, before you do the work

If you want regeneration after each monster, you might try corpse eater?

Nut wrote: ↑Thu Aug 09, 2018 2:13 pm If you want regeneration after each monster, you might try corpse eater?

Yes, I saw corpse eater, but it was not in my priority when using my skill points . For the next one perhaps!

rijackson741 wrote: ↑Thu Aug 09, 2018 1:36 pm It's by design. Regeneration does not work if you are next to a monster. Shadow regeneration works all the time.

Perhaps this should be indicated in the skill description like: “Gain health every round, except when engaged in a fight.”. I would have certainly opt for Corpse Eater if I have known that before.

rijackson741 wrote: ↑Thu Aug 09, 2018 1:36 pm This has been fixed for 0.7.2

0.7.2 is the next big one or a small bugfix release that will come any time soon?

rijackson741 wrote: ↑Thu Aug 09, 2018 1:36 pm The only difference is the time: 6s vs 25s. A condition that acts every full round would act once every 25s (there are no such conditions in 0.7.1 though)

I means there's some planned for the next releases? You said it's the only difference, but it seems if I take the code that there is a difference between monsters and character against those turns, no?

rijackson741 wrote: ↑Thu Aug 09, 2018 1:36 pm For the above, there's nothing to fix, but you would fork Zukero's repo, and then make your changes in your copy of the repo (preferably after creating a new branch), then put in a pull request. Before doing any of that it's best to ask here first though, before you do the work

Of course, it's exactly why I was posting this thread .

PomCompot wrote: ↑Thu Aug 09, 2018 2:48 pm Perhaps this should be indicated in the skill description like: “Gain health every round, except when engaged in a fight.”. I would have certainly opt for Corpse Eater if I have known that before.

It is now.

PomCompot wrote: ↑Thu Aug 09, 2018 2:48 pm 0.7.2 is the next big one or a small bugfix release that will come any time soon?

0.7.2 is the next big one that will come any time soon!

PomCompot wrote: ↑Thu Aug 09, 2018 2:48 pm I means there's some planned for the next releases? You said it's the only difference, but it seems if I take the code that there is a difference between monsters and character against those turns, no?

IIRC, there are one or two in the next release.

Seems perfect then! Thanks for the info.

To be complete, I was thinking that 0.7.2 was a bugfix version due to the versioning scheme and the increment of the patch digit .

It's still a 0.7 because there aren't that many structural changes. v0.8.0 will include changes to the game system and balancing, and potentially more code rewrites for some important parts of the engine.

OK, everything's clear now. Just expecting 0.8 as much as 0.7.2 then!

We can't hit 1.0 until the content is complete, so we need small increments