v0.8.9 (Bugfixes + translations) released to Google Play!

Useful links
Source code of the game - Contribution guide - ATCS Editor - Translate the game on Weblate - Example walkthrough - Andor's Trail Directory - Join the Discord
Get the game (v0.8.9) from Google, F-Droid, our server, or itch.io

Added a "miss" Animation

Discussions of the development process of the game.
Post Reply
Lille1_opendev2015
Posts: 7
Joined: Mon Feb 09, 2015 1:10 pm
android_version: 4.4 - Kitkat

Added a "miss" Animation

Post by Lille1_opendev2015 »

Hi ! I'm Arnaud from the Lille 1 OpenDev group !
I and Bafou added an animation when an attack misses.
The animation is based on the poison effect, with a different opacity and a white-gray color, so it looks like smoke.

I think it is better this way because before this, we didn't really know that the attack misses (except from the log) and I found it a bit disturbing.

Thank you for your feedbacks !

The link to the pull request :
https://github.com/Zukero/andors-trail/pull/10
User avatar
Zukero
Lead Developer
Posts: 2028
Joined: Thu Jul 21, 2011 9:56 am
android_version: 8.0
Location: Eclipse

Re: Added a "miss" Animation

Post by Zukero »

I like the idea, and your code is well written.
However, I don't like the animation graphics. They look too much like you successfully landed a different kind of attack (like a freeze or whatever...).
I'd also love the word "MISS" to show up just like the damage amount does when you actually land (or take) a successful attack.

If you don't have anyone to draw a convincing animation for your feature, I can try to dig in my relations for someone who may decide to care to draw one, but that'll cost me a bunch of beers :D
Lvl: 78, XP: 8622632, Gold: 271542, RoLS: 1, ElyR: -, RoL: -, ChaR: 1, GoLF: 1, ShaF: 1, SRoV: 1, VSH: 1, WMC: 1, GoW: 1
HP: 71, AC: 301%, AD: 38-47, AP: 3, ECC: 50%, CM: 3.75, BC: 101%, DR: 2
Lille1_opendev2015
Posts: 7
Joined: Mon Feb 09, 2015 1:10 pm
android_version: 4.4 - Kitkat

Re: Added a "miss" Animation

Post by Lille1_opendev2015 »

We searched how to display "MISS" but we didn't find where it was in the code. That's why we made a smoke-like animation.
Could you give us an hint about this ? =)
User avatar
Zukero
Lead Developer
Posts: 2028
Joined: Thu Jul 21, 2011 9:56 am
android_version: 8.0
Location: Eclipse

Re: Added a "miss" Animation

Post by Zukero »

Yup.
Check out VisualEffectController.startEffect(Coord position, VisualEffectCollection.VisualEffectID effectID, int displayValue, VisualEffectCompletedCallback callback, int callbackValue)
There, the "int displayValue" is used to show the damages.
An API change to make it a "String displayValue" could be the right way to do it, along with the consequences:
- The VisualEffectAnimation(...) constructor would have to also accept String instead of int, removing the need for the value check and String conversion.
- The existing callers of VisualEffectController.startEffect(...) would have to take care of their own int->String conversion, ideally reusing the one removed from VisualEffectAnimation(...) in the previous step.

Enjoy !
Lvl: 78, XP: 8622632, Gold: 271542, RoLS: 1, ElyR: -, RoL: -, ChaR: 1, GoLF: 1, ShaF: 1, SRoV: 1, VSH: 1, WMC: 1, GoW: 1
HP: 71, AC: 301%, AD: 38-47, AP: 3, ECC: 50%, CM: 3.75, BC: 101%, DR: 2
Post Reply