Andor's Trail

• DR is applied to the average damage, which doesn't account for scenarios where the low end of the damage range would be negative
• Critical hits are added to the average damage as if they happen in addition to a normal hit, rather than replacing a normal hit (effectively increasing the critical multiplier by 100%)

	private static float getAverageDamagePerHit(Actor attacker, Actor target) {
		Range scaledDamage = new Range(attacker.getDamagePotential());
		scaledDamage.subtract(target.getDamageResistance(), false);
		float result = scaledDamage.averagef();
		if (hasCriticalAttack(attacker, target)) {
			result += (float) attacker.getEffectiveCriticalChance() * result * (attacker.getCriticalMultiplier() - 1) / 100;
		}
		result = (float) (getAttackHitChance(attacker, target)) * result / 100;
		return result;
	}

• Delay applying hit chance until the end, since a miss does 0 damage no matter what
• Apply DR to the damage potential before taking the average to let the Range util class handle underflow
• Subtract 1 from the crit multiplier to avoid overcounting crit damage

QQkp wrote: ↑Sun Jan 05, 2020 5:38 am Makes sense for normal hits as long as we correctly catch cases where newAD_max < 0.

For crits, I think there's still a minor issue around the case that rijackson741 pointed out, where you can only damage an enemy with a crit. Here's a case:
AD_min = 1
AD_max = 2
CM = 2
DR = 3

Here, to damage the enemy, you must roll a 2 for damage and get a crit to overcome DR - so d_c should be 0.5. But newAD_max is only 1. If we're doing integer division, newAD_max/CM floors to 0. If we allow float, it looks like the formula works out to 0.375.

It might still be close enough for the purpose of difficulty calculation, though. I'm guessing accounting for conditions will always remain out of scope (it's much more complex, and probably isn't worth the upkeep since any future conditions would also have to be added). And fractional crit multipliers throw in another little wrinkle, since damage values are always cast back to int.